Allow Brainstorm to scale to the same height as the copied joker #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi hello, thanks for the PR! I'll take a look at your changes and try to figure out what's causing the bug you're describing. Can't promise when I'll have time, but I'll try this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolutely love your mod and thought that Brainstorm should also scale its height to fit the joker its copying, so I added some code for it to do that.
I'm not a Lua programmer, game developer, or completely read up on modding Balatro, but gave it my best shot, if you have any pointers I'll address them!
I did notice a bug I would like some help figuring out actually.
After Brainstorm has changed its height, and then changed back to normal height, for one time only when selected it stretches a bit. When you deselect it and re-select it again it behaves normally. I assume this has something to do with the caching that's going on, but I didn't fully understand that logic so I figured I'd ask if you might understand what's causing this behaviour?