fix: Do not depend on an external base64 package anymore#192
Merged
max-stytch merged 3 commits intomainfrom Feb 17, 2023
Merged
fix: Do not depend on an external base64 package anymore#192max-stytch merged 3 commits intomainfrom
max-stytch merged 3 commits intomainfrom
Conversation
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
kaden-stytch
approved these changes
Feb 17, 2023
| }); | ||
|
|
||
| test("Throws an error when given unicode input", () => { | ||
| expect(() => base64Encode("😅")).toThrow( |
austin-stytch
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#185 is causing issues in NextJS edge middleware runtimes - see #191
Let's stop depending on external base64 packages and just do it in vanilla JS.