[AUTH-5952] [STYTCH-2] Local validations for Org RBAC policies. #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-stytch
approved these changes
Jan 24, 2026
Comment on lines
+173
to
+174
| @staticmethod | ||
| def validate_org_policy(project_policy: B2BPolicy, org_policy: OrgPolicy) -> None: |
Contributor
There was a problem hiding this comment.
[dust] Totally fine here, but there are purists that try to avoid ever writing staticmethod under the thought that it should either: [1] be a classmethod that cares about the class in some way or [2] actually belongs as a free function or in another class
Contributor
Author
There was a problem hiding this comment.
Going to leave this as-is and risk the wrath of sectarian Python violence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a local helper method to validate that an Org policy does not contain obvious errors that would result in an error response from the API. Orb requested this and it seems they exclusively use the Python SDK.