next#145
Conversation
<!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/su-its/core/pull/142" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end -->
## Summary - Prismaからの移行は完了済みのため、不要になった `_prisma_migrations` テーブルのスキーマ定義とデータを削除 - Drizzleマイグレーション(`DROP TABLE "_prisma_migrations" CASCADE`)を生成 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- devin-review-badge-begin --> --- <a href="https://app.devin.ai/review/su-its/core/pull/144" target="_blank"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1"> <img src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1" alt="Open with Devin"> </picture> </a> <!-- devin-review-badge-end --> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes legacy Prisma migration artifacts from the Drizzle-managed schema and adds a Drizzle migration to drop the _prisma_migrations table so the database state matches the current Drizzle schema.
Changes:
- Delete the
_prisma_migrationstable definition from the Drizzle schema. - Add migration
0004_loose_waspto drop_prisma_migrations. - Record the updated Drizzle snapshot/journal metadata for migration tracking.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/infrastructure/drizzle/schema.ts | Removes the Drizzle table definition for _prisma_migrations. |
| drizzle/0004_loose_wasp.sql | Adds SQL migration to drop the legacy Prisma migrations table. |
| drizzle/meta/_journal.json | Registers the new migration entry in Drizzle’s journal. |
| drizzle/meta/0004_snapshot.json | Adds the schema snapshot reflecting removal of _prisma_migrations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1 @@ | |||
| DROP TABLE "_prisma_migrations" CASCADE; No newline at end of file | |||
There was a problem hiding this comment.
DROP TABLE "_prisma_migrations" CASCADE; will fail in environments where the table is already missing (e.g., someone manually removed it or a DB was created without the legacy Prisma artifacts). Consider using DROP TABLE IF EXISTS and avoid CASCADE unless you’ve verified there are dependent objects you intentionally want to remove; CASCADE can drop unexpected dependent views/constraints.
| DROP TABLE "_prisma_migrations" CASCADE; | |
| DROP TABLE IF EXISTS "_prisma_migrations"; |
Uh oh!
There was an error while loading. Please reload this page.