Skip to content

feat: OpenAPIのバージョンを1.0.0に上げる#252

Merged
h-takeyeah merged 5 commits intodevelopfrom
patch-openapi-v1
Apr 9, 2026
Merged

feat: OpenAPIのバージョンを1.0.0に上げる#252
h-takeyeah merged 5 commits intodevelopfrom
patch-openapi-v1

Conversation

@h-takeyeah
Copy link
Copy Markdown
Collaborator

@h-takeyeah h-takeyeah commented Apr 9, 2026

#251 の途中で必要になった作業をやるブランチ.これをdevelopにマージしてからそれをrelease/v1.4.0にさらにマージする.


Open with Devin

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@h-takeyeah h-takeyeah changed the base branch from release/v1.4.0 to develop April 9, 2026 16:46
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

Comment thread typing-app/src/libs/api/v1.d.ts
parameters: {
path: {
/** @description ユーザーID */
"user-id": string;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing OpenAPI path parameter name mismatch carried into v1.d.ts

The OpenAPI spec defines the path as /scores/{user_id}/current-rank (template variable user_id) but the parameter is declared with name: user-id (typing-server/openapi.yaml:200). Per the OpenAPI 3.0 spec, path parameter names MUST match the template expression. This mismatch is pre-existing (also present in v0.d.ts:199) and results in the generated types having "user-id" as the path parameter key while the path key uses {user_id}. This could cause issues with openapi-fetch or other code generators that try to correlate path parameters with path template variables.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@h-takeyeah
Copy link
Copy Markdown
Collaborator Author

v0をv1に置換する

cd typing-app
rg v0 src | grep -o '^src.*' | cut -d: -f1 | xargs -I {} sed -i 's/v0/v1/' {};

@h-takeyeah
Copy link
Copy Markdown
Collaborator Author

した

@h-takeyeah h-takeyeah changed the title chore: CIを回すためのちょい変更 feat: OpenAPIのバージョンを1.0.0に上げる Apr 9, 2026
@h-takeyeah h-takeyeah merged commit f625f05 into develop Apr 9, 2026
4 checks passed
@h-takeyeah h-takeyeah deleted the patch-openapi-v1 branch April 9, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant