add Insert Markdown Hyperlink package

[noahcoad]

• I'm the package's author and/or maintainer.
• I have have read [the docs][1].
• I have tagged a release with a [semver][2] version number.
• My package repo has a description and a README describing what it's for and how to use it.
• My package doesn't add context menu entries. *
• My package doesn't add key bindings. **
• Any commands are available via the command palette.
• Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
• If my package is a syntax it doesn't also add a color scheme. ***
• I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is similar to ... a few other Markdown packages that also have a command to insert a hyperlink

However it should still be added because ... Those other markdown packages insert just the '' base template, as they do with any other markdown shortcut, like '' for images, '#' for headers etc. This package inserts hyperlinks much more intelligently by using the selected text/url placing it the right spot, or using a url in the clipboard, then grabs the title from the url if available, and sets the selected text and cursor in the spot most needed (title or url).

[packagecontrol-bot]

Automated testing result: WARNING

Repo link: Insert Markdown Hyperlink
Results help

Packages added:
  - Insert Markdown Hyperlink

Processing package "Insert Markdown Hyperlink"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

[noahcoad]

Also the reason it's not submitted to the other markdown tools is bc those follow that same pattern of inserting the base markdown template for each syntax element. ... also added a LICENCE file thanks to the package processing message, thanks.

[braver]

Suggested change

	"labels": ["markdown", "hyperlink", "url", "link"],
	"labels": ["markdown", "url", "link"],

hyperlink is not a label that already exists, and doesn't feel like it really adds much. It feels very 1990's to be talking about "hyperlinks" 😅

[noahcoad]

Thank you for the feedback. Will address.

[braver]

I'd love to publish your packages, but all 3 PR's have feedback on them that needs to be handled first.

[braver]

It sounds a little bit like what MarkdownLink tries do to. But different enough to be a good addition to the ecosystem.

Only thing I see in the package itself is that the example keymap isn't used. You could link it in Package Settings (except you don't have any settings). For both settings and key bindings it's common practice to have them in the command palette as well, so you could consider that too.

[noahcoad]

It sounds a little bit like what MarkdownLink tries do to. But different enough to be a good addition to the ecosystem.

Good find. Actually it's quite similar. Mine has more intelligence in a way around other options, like using what's in the clipboard or selected text (url or not). I'll reach out to the author to see if they're open to me enhancing their package.

[noahcoad]

Only thing I see in the package itself is that the example keymap isn't used. You could link it in Package Settings (except you don't have any settings). For both settings and key bindings it's common practice to have them in the command palette as well, so you could consider that too.

Can you say more? Thought the best practice was to not use a keymap by default (hence I had recommended keymap in there), but I'd certainly like to include a default package keymap settings w the one key mapped if that's okay.

And good point about having the keycap in the settings. I'll add that.

[braver]

Can you say more

This is a good example: https://github.com/Mister7F/sublime-telescope/blob/master/Default.sublime-keymap. The map is there, there is a menu entry for it, but it's disabled. As a user all you need to do is copy the binding from left to right to your personal keymap, and adjust if needed.

[braver]

Let me know when you've had a chance to look at the feedback!