Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions repository/e.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
{
"schema_version": "3.0.0",
"packages": [
{
"details": "https://github.com/kaessajidi/ekl-sublim-text",
"name": "Dassault Systemes EKL Syntax",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Dassault Systemes EKL Syntax",
"name": "Dassault Systemes EKL",

Language support packages don't need to have "syntax" or something like it in the name, since typically it does more than just the syntax: in your case it also provides completions (which you might want to specify in the labels).

If you want to call it Dassault Systemes EKL and not just EKL, it should go into the d.json file instead, an in alphabetical order there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to call it Dassault Systemes EKL and not just EKL, it should go into the d.json file instead, an in alphabetical order there.

You missed this point I'm afraid.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 your PR is not mergeable in its current state.

"author": "Kamal Essa",
"labels": ["language syntax"],
"releases": [
{
"sublime_text": "*",
"tags": true
}
]
},
{
"details": "https://github.com/glyph/E-Max",
"releases": [
Expand Down
Loading