Cleaned up environment variables in prep for heroku #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… were no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to keep all of my config settings in environment variables so I did some work to clean up your TODO's. In addition, I ran into a problem with my-connect-redis. Coincidentally, cleaning up the environment variables seemed to get rid of any need for this version so I just reverted it back to the packaged connect-redis.
I also found a problem with getPlaybackToken that was resolved when I removed the hardcoded domain.
All in all, this has allowed me to deploy my own version to heroku without having to check api keys into git.
One big change that you'll notice is that the dev environment connects to a local redis now rather than a special redistogo account. I pretty much stole this from the way that github set up the hubot environment. This might break things for you but I figured that redis is just a
brew install redisso it's not much of a challenge for folks.Thoughts?