Solved warnings so that compilation with g++ -Werror=conversion and -Werror=switch-default is possible.#282
Open
serpedon wants to merge 2 commits intosui77:masterfrom
Open
Solved warnings so that compilation with g++ -Werror=conversion and -Werror=switch-default is possible.#282serpedon wants to merge 2 commits intosui77:masterfrom
serpedon wants to merge 2 commits intosui77:masterfrom
Conversation
…Werror=switch-default is possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved warnings so that compilation with g++ -Werror=conversion and -Werror=switch-default is possible.
With these changes, compilation with g++ treating warnings as errors is possible. To my understanding, the warnings are relevant (e.g. possible integer overflow).
Note: This changes modify the external interfaces since I did not want to change "struct Protocol". This will introduce a conversion-warning for users which still use the old types in there code. But these users evidently have conversion-warnings disabled since otherwise they would not be able to compile rc-switch without these changes in the first place.
Please review if you agree with my correction suggestion.