enable proper multi instances of rc-switch + improved interrupt routine speed#346
Open
danyhm wants to merge 9 commits intosui77:masterfrom
Open
enable proper multi instances of rc-switch + improved interrupt routine speed#346danyhm wants to merge 9 commits intosui77:masterfrom
danyhm wants to merge 9 commits intosui77:masterfrom
Conversation
already compatible with stm32duino
move changeCount check to interrupt handler main routine in order to reduce overhead of calculations in the receiveProtocol() function.
enable multi instances of rc-switch support.
enable multi instances of rc-switch support.
1technophile
reviewed
Jul 2, 2020
| volatile unsigned int RCSwitch::nReceivedBitlength = 0; | ||
| volatile unsigned int RCSwitch::nReceivedDelay = 0; | ||
| volatile unsigned int RCSwitch::nReceivedProtocol = 0; | ||
| int RCSwitch::nReceiveTolerance = 60; |
Collaborator
There was a problem hiding this comment.
I can't find where nReceiveTolerance is set on the new version, do I miss something?
Contributor
Author
There was a problem hiding this comment.
Hi,
yes it's part of the class and in RCSwitch.h file
library.properties
Outdated
| category=Device Control | ||
| url=https://github.com/sui77/rc-switch | ||
| architectures=avr,esp8266,esp32 | ||
| architectures=avr,esp8266,esp32,stm32 |
Collaborator
There was a problem hiding this comment.
This change should not be here
Contributor
Author
There was a problem hiding this comment.
it's form the last commit. I don't know how to pull from your repo again.... not a git pro
Contributor
Author
There was a problem hiding this comment.
This change should not be here
I just found out this doesn't work for non ARM avrs because std::bind is not available.
|
so now can I use this from your library and proper multi instances/?? |
this update adds support for RP2040 cores and some minor fixes for stm32. for now I have to remove AVR support because of the attachInterupt function callback problem not being supported.
notes for future development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR enables multi instances of RC-switch where usage of more than 1 RC module in one sketch is possible (ie. 433 + 315)
fix #345