Skip to content

support signing empty param values, e.g. 's.q=' #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magibney wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support signing empty param values, e.g. 's.q=' #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/summon/transport/headers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def digest
end

def qstr
to_query_string(@params, false)
to_query_string(@params, false, lambda {|k,v| v.nil? })
end

private
Expand Down
5 changes: 3 additions & 2 deletions lib/summon/transport/qstring.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
module Summon::Transport
module Qstring

def to_query_string(hash, urlencode = true)
hash.reject {|k,v| v.nil? || v == ''}.inject([]) do |qs,pair|
def to_query_string(hash, urlencode = true,
reject = lambda {|k,v| v.nil? || v == ''})
hash.reject(&reject).inject([]) do |qs,pair|
qs.tap do
k,v = pair
if v.is_a?(Array)
Expand Down