Skip to content

Fixed a bug in regridding.weights() where the units of the coordinates weren't being converted. #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roytsmart merged 3 commits into from
Apr 11, 2026
Merged

Fixed a bug in regridding.weights() where the units of the coordinates weren't being converted. #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
073ba97
Fixed a bug in `regridding.weights()` where the units of the coordina…
roytsmart Apr 11, 2026
f06d7e2
fix
roytsmart Apr 11, 2026
1121a8b
coverage
roytsmart Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions regridding/_regrid/_tests/test_regrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@
None,
np.square(np.linspace(-1, 1, num=11)),
),
(
(np.linspace(-1, 1, num=11) * u.mm,),
(np.linspace(-1, 1, num=11) * u.mm,),
np.square(np.linspace(-1, 1, num=11)),
None,
None,
None,
np.square(np.linspace(-1, 1, num=11)),
),
(
(np.linspace(-1, 1, num=11),),
(np.linspace(-1, 1, num=11),),
Expand Down
9 changes: 9 additions & 0 deletions regridding/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ def _normalize_input_output_coordinates(
if isinstance(coordinates_output, np.ndarray):
coordinates_output = (coordinates_output,)

coordinates_input = list(coordinates_input)
for i in range(len(coordinates_input)):
coord_input = coordinates_input[i]
coord_output = coordinates_output[i]
if hasattr(coord_output, "unit"):
coord_input = coord_input << coord_output.unit
coordinates_input[i] = coord_input
coordinates_input = tuple(coordinates_input)

shape_coordinates_input = np.broadcast(*coordinates_input).shape
shape_coordinates_output = np.broadcast(*coordinates_output).shape

Expand Down
Loading