[EUV2][HuuHV] Create UT for Ex3 to Ex7#33
Open
huuhv-0372 wants to merge 7 commits intosun-unit-test-training:masterfrom
Open
[EUV2][HuuHV] Create UT for Ex3 to Ex7#33huuhv-0372 wants to merge 7 commits intosun-unit-test-training:masterfrom
huuhv-0372 wants to merge 7 commits intosun-unit-test-training:masterfrom
Conversation
anhnv-0443
reviewed
Jun 3, 2021
| /** | ||
| * @dataProvider inputData | ||
| */ | ||
| public function testCalculate($time, $data) |
There was a problem hiding this comment.
Name của function nên clear chút nữa ạ
| $this->assertEquals([ | ||
| 'bill' => 'required|integer|min:0', | ||
| 'has_watch' => 'nullable|boolean', | ||
| ], $request->rules()); |
There was a problem hiding this comment.
Viết như này ko sai, nhưng không khuyến khích a ạ
https://sun-unit-test-training.github.io/php-testing-guideline/laravel/03-controller/#unit-test
|
|
||
| function handleDiscountData() | ||
| { | ||
| /*return [ |
There was a problem hiding this comment.
mấy cái comment này ko dùng thì xóa đi thôi a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/Notes
Screenshot
Checklist (*)