Open
Conversation
tuanpt-0634
reviewed
Jul 28, 2020
tests/C0/UsernameValidationTest.php
Outdated
| class UsernameValidationTest extends TestCase | ||
| { | ||
| // TODO: write 6 tests to coverage 100% code | ||
| public function test_return_false_when_user_name_lt_min_length_is_valid_test() |
Member
There was a problem hiding this comment.
Các test case của e có thêm hậu tố _is_valid_test để làm gì nhể? Để biết là đang test method isValid() hả. Theo anh thì không cần nhé, coi cả class là 1 unit, chúng ta đang đi test hành vi (public api) của class
tuanpt-0634
reviewed
Jul 28, 2020
tests/C0/ProcessRunnerTest.php
Outdated
| $this->assertFalse($sut->wasProcess4Called()); | ||
| } | ||
|
|
||
| public function test_return_2_WHEN_pass_case_2_case_4_run_test() |
Member
There was a problem hiding this comment.
Mặc dù 100% code coverage, nhưng rõ là chưa đủ test case cho nó nhỉ :D
Author
There was a problem hiding this comment.
Đã đủ đk cover C0 nhưng chưa đủ các test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/Notes (*)
(E.g. Add tests for class, add docs...)
Coverage (*)
(PHPUnit coverage screenshot)
Checklist (*)