Skip to content

Course search #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Radheshhathwar wants to merge 5 commits into
base: release-4.8.0
Choose a base branch
from
Open

Course search #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c1a169
Changes by chandni
Radheshhathwar Oct 27, 2022
bef17d7
Changes for course search api
Radheshhathwar Nov 9, 2022
0e345d5
course search api changes
Radheshhathwar Nov 9, 2022
08da9aa
Changes for course search api
Radheshhathwar Nov 9, 2022
8d56aea
Merge remote-tracking branch 'origin/CourseSearch' into CourseSearch
Radheshhathwar Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions search-api/search-core/src/main/java/org/sunbird/search/processor/SearchProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,8 +935,7 @@ private QueryBuilder getSearchQuery(SearchDTO searchDTO) {
}

private QueryBuilder getQuery(SearchDTO searchDTO) {
return searchDTO.isFuzzySearch() ? prepareFilteredSearchQuery(searchDTO) : prepareSearchQuery(searchDTO);
}

return searchDTO.isFuzzySearch() ? (prepareSearchQuery(searchDTO) == null ? prepareFilteredSearchQuery(searchDTO) : prepareSearchQuery(searchDTO)) : prepareSearchQuery(searchDTO);
Copy link

@karthik-tarento karthik-tarento Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the chances of prepareSearchQuery becomes null ?
If prepareSearchQuery is not null - then the default SB behaviour of calling prepareFilteredSearchQuery won't be used in Sunbird environment. So this solution can not be proposed to Sunbird - we need better way of coding which is not causing any issues in Sunbird environment.


}
}
2 changes: 1 addition & 1 deletion search-api/search-service/conf/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ search.config.path=/home/learning/platform/search
cache.type="redis"

search.es_conn_info="localhost:9200"
search.fields.query=["name^100","title^100","lemma^100","code^100","domain","subject","description^10","keywords^100","ageGroup^10","filter^10","theme^10","genre^10","objects^25","contentType^100","language^200","teachingMode^25","skills^10","learningObjective^10","curriculum^100","gradeLevel^100","developer^100","attributions^10","identifier^100","IL_UNIQUE_ID^100","owner^50","board^100","relatedBoards^100","creator^100", "dialcodes^100","text","words","releaseNotes"]
search.fields.query=["name^100.0","keywords^60.0","competencies_v3.name^60.0","systemTopics^60","purpose^60","source^50.0","description^5.0","language^5.0"]
Copy link

@karthik-tarento karthik-tarento Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this can be over ridden via deployment script -- so that no code change is required.

search.fields.date=["lastUpdatedOn","createdOn","versionDate","lastSubmittedOn","lastPublishedOn"]
search.fields.mode_collection=["identifier","name","objectType","contentType","mimeType","size","childNodes","board","subject","medium","gradeLevel","appIcon", "origin", "originData"]
search.batch.size=500
Expand Down