[Memory] Fix large memory usage during __init__ call. #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com>
Collaborator
Author
|
Before this fix: |
Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com>
Collaborator
Author
|
After this fix: |
Collaborator
Author
|
Note: this does not fix the memory issue when we set task (that would still blow up the memory, and will be fix the subsequence PRs) |
Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com>
Collaborator
Author
|
@jhnwu3, this lowername op seems to have no effect? attribute_columns = [
pl.col(attr.lower()).alias(f"{table_name}/{attr}") for attr in attribute_cols
]changes it back to upper name anyways? |
dalloliogm
reviewed
Nov 19, 2025
jhnwu3
approved these changes
Nov 19, 2025
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
Thanks for the catch, I did find a new bug now where num_workers > 4, the tqdm doesn't show for some reason. Will investigate further.
dalloliogm
pushed a commit
to dalloliogm/PyHealth
that referenced
this pull request
Nov 26, 2025
* Add script to test memory usage of dataset Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com> * Remove collect_schema usage during __init__ Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com> * Fix some code still accessing upper case column name Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com> --------- Co-authored-by: John Wu <54558896+jhnwu3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor: Yongda Fan (yongdaf2@illinois.edu), John Wu
Contribution Type: Datasets
Description
Fix the large memory usage during dataset's
__init__call.The PR #601 has been used as a reference.