Skip to content

Kernel: Use SeqCst for ARE_CPU_LOCALS_INIT #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roblabla wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kernel: Use SeqCst for ARE_CPU_LOCALS_INIT #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernel/src/cpu_locals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ pub fn init_cpu_locals(cpu_count: usize) {
});

// yes, they are 😌
ARE_CPU_LOCALS_INITIALIZED_YET.store(true, Ordering::Relaxed);
ARE_CPU_LOCALS_INITIALIZED_YET.store(true, Ordering::SeqCst);
}

/// The `round` function, as defined in section 3.0:
Expand Down
2 changes: 1 addition & 1 deletion kernel/src/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ static CURRENT_THREAD: RefCell<Option<Arc<ThreadStruct>>> = RefCell::new(None);
pub fn try_get_current_thread() -> Option<Arc<ThreadStruct>> {
// if cpu_locals haven't been initialized, accessing gs:0 will triple fault,
// so don't even remotely try to access it.
if !ARE_CPU_LOCALS_INITIALIZED_YET.load(Ordering::Relaxed) {
if !ARE_CPU_LOCALS_INITIALIZED_YET.load(Ordering::SeqCst) {
None
} else {
CURRENT_THREAD.borrow().clone()
Expand Down