[WIP] make more integer types DefaultsSerializable#190
Open
DivineDominion wants to merge 1 commit intosunshinejr:masterfrom
Open
[WIP] make more integer types DefaultsSerializable#190DivineDominion wants to merge 1 commit intosunshinejr:masterfrom
DivineDominion wants to merge 1 commit intosunshinejr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with
UInt, but the obvious next step would be to add Int64/32/16/8 and UInt64/32/16/8.The code is pretty repetitive. In other projects, we used a code generator for this to prevent typos and code that's getting on one's nerves to maintain. But for 8 new types and their tests, we could stick with manual implementations just as well.