make DefaultsKey.defaultValue publicly readable#191
Merged
sunshinejr merged 1 commit intosunshinejr:masterfrom Apr 19, 2019
Merged
make DefaultsKey.defaultValue publicly readable#191sunshinejr merged 1 commit intosunshinejr:masterfrom
sunshinejr merged 1 commit intosunshinejr:masterfrom
Conversation
sunshinejr
approved these changes
Apr 19, 2019
Owner
sunshinejr
left a comment
sunshinejr
left a comment
There was a problem hiding this comment.
Thanks @DivineDominion! Would you please add a changelog entry and rebase/merge master into your branch?
Contributor
Author
|
Rebase? Sure, done :) |
DivineDominion
force-pushed
the
public-defaultvalue
branch
from
d0e2f25 to
4b68a14
Compare
Owner
|
thanks @DivineDominion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should make 3rd party extensions like #165 easier, and implementations of
register(defaults:)possible. Can precede #189