Open
Conversation
|
@dp221125 Thank you for your pull request! Since NSPrivacyCollectedDataTypes is not included in PrivacyInfo, will there be no error when generating a Privacy Report? |
Author
Author
|
@sunshinejr could you review PR, please? |
@sunshinejr Please merge pr |
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.0 | |||
| // swift-tools-version:5.3 | |||
There was a problem hiding this comment.
Having this set at version 5.0 could be important for some projects. The way to make sure it can still work for those people would be to create a Package@swift-5.0.swift file which has the original 5.0 tools version.
Anyone requiring that version would be well used to having to manually handle the privacy manifest for their dependencies. And anyone using a version 5.3 or higher would get this Package.swift package description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a privacy manfiest (PrivacyInfo.xcprivacy), Apple has not been mentioned here, but this SDK is using the User Defaults API
Additionally, since the
swift-tools-versionin Package.swift is set to 5.0, it was not possible to add resources to the target. Functions that include resources available from version 5.3, so I have updated it to 5.3. (swift-package-manager github)resolve #299 #300