Skip to content

fix: add auto_reconnect to the Postgrex.Notifications #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abc3 wants to merge 2 commits into from
Closed

fix: add auto_reconnect to the Postgrex.Notifications #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdffcf9
fix: add auto_reconnect to the Postgrex.Notifications
abc3 May 26, 2025
71c67ce
bump version
abc3 May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions lib/strategy.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,31 @@ defmodule LibclusterPostgres.Strategy do
alias Cluster.Strategy
alias Cluster.Logger

@type config :: [
hostname: String.t(),
username: String.t(),
password: String.t(),
database: String.t(),
port: non_neg_integer(),
parameters: keyword(),
ssl: boolean(),
ssl_opts: keyword() | nil,
socket_options: keyword() | nil,
channel_name: String.t(),
heartbeat_interval: non_neg_integer()
]

@type meta :: %{
opts: fun(),
conn: Postgrex.conn() | nil,
conn_notif: pid() | nil,
heartbeat_ref: reference()
}

def start_link(args), do: GenServer.start_link(__MODULE__, args)

@spec init([%{:config => any(), :meta => any(), optional(any()) => any()}, ...]) ::
{:ok, %{:config => list(), :meta => map(), optional(any()) => any()},
@spec init([%{:config => config(), :meta => any(), optional(any()) => any()}, ...]) ::
{:ok, %{:config => config(), :meta => meta(), optional(any()) => any()},
{:continue, :connect}}
def init([state]) do
channel_name = Keyword.get(state.config, :channel_name, clean_cookie(Node.get_cookie()))
Expand All @@ -36,14 +57,16 @@ defmodule LibclusterPostgres.Strategy do
ssl_opts: Keyword.get(state.config, :ssl_opts),
socket_options: Keyword.get(state.config, :socket_options, []),
parameters: Keyword.get(state.config, :parameters, []),
channel_name: channel_name
channel_name: channel_name,
auto_reconnect: true,
reconnect_backoff: :timer.seconds(5)
]

config =
state.config
|> Keyword.put_new(:channel_name, channel_name)
|> Keyword.put_new(:heartbeat_interval, 5_000)
|> Keyword.delete(:url)
|> Keyword.put_new(:heartbeat_interval, :timer.seconds(5))
|> Keyword.delete(:password)

meta = %{
opts: fn -> opts end,
Expand All @@ -56,8 +79,10 @@ defmodule LibclusterPostgres.Strategy do
end

def handle_continue(:connect, state) do
with {:ok, conn} <- Postgrex.start_link(state.meta.opts.()),
{:ok, conn_notif} <- Postgrex.Notifications.start_link(state.meta.opts.()),
opts = state.meta.opts.()

with {:ok, conn} <- Postgrex.start_link(opts),
{:ok, conn_notif} <- Postgrex.Notifications.start_link(opts),
{_, _} <- Postgrex.Notifications.listen(conn_notif, state.config[:channel_name]) do
Logger.info(state.topology, "Connected to Postgres database")

Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defmodule LibclusterPostgres.MixProject do
[
name: "libcluster_postgres",
app: :libcluster_postgres,
version: "0.1.3",
version: "0.1.4",
elixir: "~> 1.14",
start_permanent: Mix.env() == :prod,
deps: deps(),
Expand Down