fix: Better to override that during the upgrade process by specifying the option directly when pg_upgrade is executed (-c)

Author: samrose

ansible/files/admin_api_scripts/pg_upgrade_scripts/complete.sh

@@ -22,9 +22,6 @@ function cleanup {
 
     ship_logs "$LOG_FILE" || true
 
-    # Restore max_slot_wal_keep_size to 4096 after binary upgrade
-    sed -i 's/max_slot_wal_keep_size = -1/max_slot_wal_keep_size = 4096/' /etc/postgresql/postgresql.conf
-
     # Restart postgres to apply any configuration changes
     if [ -z "$IS_CI" ]; then
         systemctl restart postgresql

ansible/files/admin_api_scripts/pg_upgrade_scripts/initiate.sh

@@ -397,9 +397,6 @@ function initiate_upgrade {
     chown -R postgres:postgres "$MOUNT_POINT/"
     rm -rf "${PGDATANEW:?}/"
 
-    # Change max_slot_wal_keep_size to -1 for binary upgrade
-    sed -i 's/max_slot_wal_keep_size = [0-9]*/max_slot_wal_keep_size = -1/' /etc/postgresql/postgresql.conf
-
     if [ "$IS_NIX_UPGRADE" = "true" ]; then
         if [[ "$PGVERSION" =~ ^17.* || "$PGVERSION" == "17-orioledb" ]]; then
             LC_ALL=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LANGUAGE=en_US.UTF-8 LANG=en_US.UTF-8 LOCALE_ARCHIVE=/usr/lib/locale/locale-archive su -c ". /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh && $PGBINNEW/initdb --encoding=$SERVER_ENCODING --locale-provider=icu --icu-locale=en_US.UTF-8 -L $PGSHARENEW -D $PGDATANEW/ --username=supabase_admin" -s "$SHELL" postgres
@@ -430,8 +427,10 @@ $(cat /etc/postgresql/pg_hba.conf)" > /etc/postgresql/pg_hba.conf
     --jobs="${WORKERS}" -r \
     --old-options='-c config_file=${POSTGRES_CONFIG_PATH}' \
     --old-options="-c shared_preload_libraries='${SHARED_PRELOAD_LIBRARIES}'" \
+    --old-options="-c max_slot_wal_keep_size=-1" \
     --new-options="-c data_directory=${PGDATANEW}" \
-    --new-options="-c shared_preload_libraries='${SHARED_PRELOAD_LIBRARIES}'"
+    --new-options="-c shared_preload_libraries='${SHARED_PRELOAD_LIBRARIES}'" \
+    --new-options="-c max_slot_wal_keep_size=-1"
 EOF
     )
 

ansible/vars.yml

@@ -9,9 +9,9 @@ postgres_major:
 
 # Full version strings for each major version
 postgres_release:
-  postgresorioledb-17: "17.0.1.078-orioledb-upgrade-4"
-  postgres17: "17.4.1.028-upgrade-4"
-  postgres15: "15.8.1.085-upgrade-4"
+  postgresorioledb-17: "17.0.1.078-orioledb-upgrade-5"
+  postgres17: "17.4.1.028-upgrade-5"
+  postgres15: "15.8.1.085-upgrade-5"
 
 # Non Postgres Extensions
 pgbouncer_release: "1.19.0"