fix: remove duplicate slash in tus upload url generator #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20041649574Details
💛 - Coveralls |
ferhatelmas
reviewed
Nov 18, 2025
| const forwardedPath = req.headers['x-forwarded-prefix'] | ||
| if (requestAllowXForwardedPrefix && typeof forwardedPath === 'string') { | ||
| basePath = forwardedPath + path | ||
| // Remove trailing slash from forwardedPath to avoid double slashes |
There was a problem hiding this comment.
Similar pattern could happen for signV4 of canonical request if this feature requestAllowXForwardedPrefix is enabled or a configuration value ending with a slash is given. I believe, as a result, it can cause SignatureDoesNotMatch errors
Contributor
Author
There was a problem hiding this comment.
Good catch. This (and the original issue) does not impact our hosted service because we do not have a trailing slash, but for self hosted people may want to configure it (nginx, envoy, etc) with a trailing slash and that would cause S3 signature mismatch.
aantti
changed the title
itslenny
force-pushed
the
fix/strip-extra-slash-from-tus-path
branch
from
1251a82 to
8e5c8cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Paths returned by TUS during multi-part uploads include a duplicate slash when adding the forwarded path prefix
Example:
/storage/v1//upload/resumable/abc123What is the new behavior?
Remove duplicate slash (
/storage/v1/upload/resumable/abc123)Additional context
Thanks for the report @aantti