Skip to content

fix(storage): correct exists() error handling for non-existent files #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(storage): correct exists() error handling for non-existent files #1745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/core/storage-js/src/packages/StorageFileApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { isStorageError, StorageError, StorageUnknownError } from '../lib/errors'
import { isStorageError, StorageError, StorageUnknownError, StorageApiError } from '../lib/errors'
import { Fetch, get, head, post, put, remove } from '../lib/fetch'
import { recursiveToCamel, resolveFetch } from '../lib/helpers'
import {
Expand Down Expand Up @@ -600,14 +600,21 @@ export default class StorageFileApi {
if (this.shouldThrowOnError) {
throw error
}
if (isStorageError(error) && error instanceof StorageUnknownError) {
const originalError = error.originalError as unknown as { status: number }
if (isStorageError(error)) {
// Check for both StorageApiError (which has status directly) and StorageUnknownError (with originalError)
let status: number | undefined

if (error instanceof StorageApiError) {
status = error.status
} else if (error instanceof StorageUnknownError) {
const originalError = error.originalError as unknown as { status: number }
status = originalError?.status
}

if ([400, 404].includes(originalError?.status)) {
return { data: false, error }
if (status && [400, 404].includes(status)) {
return { data: false, error: null }
}
}

throw error
}
}
Expand Down