Skip to content

Conversation

@mgpadshala
Copy link

Complete DP-1

@super30admin
Copy link
Owner

  • Strengths:

    • Both solutions are correct and efficient, demonstrating a good understanding of dynamic programming and memoization.
    • The code is well-organized, with clear comments and docstrings that enhance readability.
    • The use of memoization in the rob method is a great way to optimize the solution.
  • Areas for Improvement:

    • In the coin_change function, the initial value of amount + 1 to represent infinity is a good choice, but it might be worth mentioning in the docstring why this value is chosen.
    • For the rob method, consider adding a docstring to explain the method's purpose and arguments, similar to the coin_change function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants