Skip to content

Conversation

@Dheepthi-Reddy
Copy link

  • Solved Coin Change
  • Solved House Robber

@super30admin
Copy link
Owner

Strengths:

  • The student has demonstrated a good understanding of dynamic programming concepts.
  • The solutions are well-commented and easy to follow.
  • The House Robber solution is optimally implemented in terms of both time and space complexity.

Areas for Improvement:

  • For the coin change problem, consider optimizing the space complexity by using a 1D array instead of a 2D array. This would reduce the space complexity from O(m*n) to O(n).
  • The comment "filling first column with infinity" is slightly misleading since the code actually fills the first row (not column) with a large value (amount+1). Ensure comments accurately reflect the code.
  • The initialization of the DP table could be made clearer by explicitly stating why amount+1 is used (as a stand-in for infinity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants