Pausing an animatable should pause all children#97
Open
sgrif wants to merge 1 commit intosupereggbert:masterfrom
Open
Pausing an animatable should pause all children#97sgrif wants to merge 1 commit intosupereggbert:masterfrom
sgrif wants to merge 1 commit intosupereggbert:masterfrom
Conversation
I've had need to pause the animations on an entire scene. If the model is complex, manually attempting to do this will cause about a ~1ms difference between different bones on the model. Having this not recurse by default can also cause unexpected behavior when calling `setPause` on a scene. The scene will stop rendering, but unpausing will cause it to jump forward to the frame it would have been on otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've had need to pause the animations on an entire scene. If the model
is complex, manually attempting to do this will cause about a ~1ms
difference between different bones on the model.
Having this not recurse by default can also cause unexpected behavior
when calling
setPauseon a scene. The scene will stop rendering, butunpausing will cause it to jump forward to the frame it would have been
on otherwise.