Updated NOAA API call in node-helper #2
Open
KoboseHome wants to merge 6 commits intosupermem613:mainfrom
Open
Conversation
Replacing the original node_helper with one that was generate using Gemini for MMM-NOAAWeatherForecast.
based on the changes made to node helper to generate the jsons, this has been updated to process those payloads properly.
| /********************************* | ||
|
|
||
| Node Helper for MMM-NOAAForecast. | ||
| Node Helper for MMM-NOAAForecastDeluxe. |
There was a problem hiding this comment.
The change to MMM-NOAAForecastDeluxe makes no sense in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to get this to work as written on my module, however I was having issues getting, and processing the data from the API call (see issue). I was also having issues using the data from the call in the module itself. I ended up playing with it on my own for a while until I got something that worked, with the help of Gemini. I also made a small change in the main module to use the pre-parsed jsons. After those two changes, the module was able to pull the data and now displays on my dashboard.