fix(net): --no-net actually air-gaps the guest#647
Merged
toksdotdev merged 4 commits intomainfrom May 1, 2026
Merged
Conversation
--no-net was not actually air-gapping the guest. with no virtio-net attached, libkrun silently bridged the guest's tcp/udp sockets to the host through a vsock fallback, so traffic still reached the network even though `ip a` showed only `lo`. bumped msb_krun to a libkrun fork that flips the default the other way: guests with no virtio-net are air-gapped, and TSI is opt-in. fixes #645
# Conflicts: # crates/filesystem/Cargo.toml # crates/network/Cargo.toml # crates/runtime/Cargo.toml
5 tasks
appcypher
added a commit
that referenced
this pull request
May 3, 2026
## TL;DR Bump every microsandbox crate, the node-ts and Python SDKs, the mcp submodule, and the TypeScript example pins from 0.4.3 to 0.4.4 in preparation for the next release. ## Description - Workspace `Cargo.toml` and all internal `microsandbox-*` path-dep version pins moved to 0.4.4 (cli, microsandbox, runtime, network, image, filesystem, agentd). - node-ts SDK package version, three `npm/<target>/package.json` binaries, `package-lock.json`, and the `native/index.cjs` version-check guards updated to 0.4.4. - Python SDK and node-ts SDK Cargo manifests bumped to depend on `microsandbox 0.4.4` and `microsandbox-network 0.4.4`. - mcp submodule pointer advanced to its own 0.4.4 bump (server `version`, package `version`, and `microsandbox` dep). - All 15 TypeScript example `package.json` files plus the three checked-in `package-lock.json` files (init-handoff, logs-read, shell-attach) bumped from 0.4.3 to 0.4.4. - Cargo lockfiles regenerated for both the workspace and the standalone `crates/agentd` workspace. Changelog since v0.4.3: - feat(agentd): hand off PID 1 to a guest init binary (#653) - feat(snapshot): file-first disk snapshots across cli, rust, ts, python (#652) - feat(logs): exec.log capture, boot-error.json, typed ExecFailed (#650) - fix(net): --no-net actually air-gaps the guest (#647) - fix(node-sdk): ship libkrunfw under canonical name in npm platform package (#648) ## Test Plan - [x] `cargo build --workspace` exits 0 - [x] `cargo build` inside `crates/agentd` exits 0 - [x] `npm publish --dry-run` in `sdk/node-ts` reports `microsandbox@0.4.4` - [x] `npm publish --dry-run` in `mcp` reports `microsandbox-mcp@0.4.4` - [x] `grep -r '"0\.4\.3"' .` returns no microsandbox-related hits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
--no-netwas not actually air-gapping the guest. with no virtio-net attached, libkrun silently bridged the guest's tcp/udp sockets to the host, so traffic still reached the network even thoughip ashowed onlylo.fixes #645.
fix
bumped
msb_krunto a libkrun fork that flips the default: guests with no virtio-net are air-gapped, and the host-bridge fallback is opt-in.Need help on this PR? Tag
@codesmithwith what you need.