Setup priv package #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krukonshedul
reviewed
Dec 2, 2024
Argonus
force-pushed
the
publish-forked-package
branch
from
b4f45b7 to
103931e
Compare
Add resource version parameter for kubernates strategy.
Argonus
force-pushed
the
publish-forked-package
branch
from
a2a3127 to
76dba55
Compare
emancu
reviewed
Dec 3, 2024
emancu
left a comment
emancu
left a comment
There was a problem hiding this comment.
Change seems ok for me. I dont fully understand why you use resourceVersion, what is the reasoning behind that change.
How does this change will reduce the API calls to kubernetes 🤔 ?
| use Mix.Project | ||
|
|
||
| @version "3.4.1" | ||
| @version "4.0.0" |
Collaborator
Author
There was a problem hiding this comment.
@emancu it's just our fork, not origin.
There was a problem hiding this comment.
But why not doing changes taht can be contributed back to the original project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I'll review the commits, so I mostly want to understand the "why" rather than the "what"
Checklist