Addressing a number of miscellaneous changes from #660#680
Addressing a number of miscellaneous changes from #660#680pshriwise merged 26 commits intosvalinn:developfrom
Conversation
gonuke
changed the title
uwuw and tallyuwuw, tally, and overlap_check
|
(I disabled notification on this.) Please ping me when this needs review :) |
gonuke
changed the title
uwuw, tally, and overlap_check
|
This should be ready for review @bam241 - not sure why tests aren't running? |
|
this happends some times... |
|
I manually restarted the failed build, this allowed GitHub to pick it up |
src/overlap_check/ProgressBar.hpp
Outdated
| ~ProgressBar(); | ||
| ~ProgressBar() { | ||
| if (need_final_newline) { | ||
| std::cout << "\n"; |
There was a problem hiding this comment.
maybe there we would want a endl to flush the buffer ?
There was a problem hiding this comment.
👍
\n should be the same as std::endl, but endl may be safer across platforms.
There was a problem hiding this comment.
I thought endl would force the flush, where \n would not ?
|
astyle is failing, but not on my machine. I'm using v3.0.1... what to do??? :( |
|
we could move to I'll take a look and PR against your branch |
|
It's just one file.... |
astyle on test_KDENeighborhood.cpp
I have 3.1 |
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
Just a few comments/questions. Looks really good overall to me.
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
|
Will merge at the end of the day if there are no further comments. |
3 participants
Description
Implement code updates from #660 in
uwuwtallyoverlap_checkbuild_obbmisc/testsMotivation and Context
These changes were proposed by the professional PullRequest review
Changes
These are largely syntax changes that don't impact the logic of the code.
Behavior
There is no change in behavior.
Other Information
Other relevant information to this pull request.