Convert CRLF for script bin files #314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
marsam
reviewed
Mar 4, 2023
lilyinstarlight
force-pushed
the
fix/crlf-pkgs
branch
from
090516b to
8a6ed33
Compare
lilyinstarlight
changed the title
After we started generating our own bin links, we did not provide the line-ending normalization that npm did. This corrects that to have similar behavior to before for packages with CRLF line-endings. This also has a drive-by change to remove the unnecessary `patchShebangs` due to the `patchShebangsAuto` hook running and finding these files just fine now.
lilyinstarlight
force-pushed
the
fix/crlf-pkgs
branch
from
8a6ed33 to
91aa511
Compare
marsam
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we started generating our own bin links in #302, we did not provide the line-ending normalization that npm did
This PR corrects that to have similar behavior to before for packages with CRLF line-endings