Skip to content

Conversation

@sacrosanctic
Copy link
Contributor

closes #809

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

🦋 Changeset detected

Latest commit: b38a211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 22, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@810
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@810

commit: b38a211

@sacrosanctic sacrosanctic marked this pull request as draft November 22, 2025 14:29
@sacrosanctic
Copy link
Contributor Author

I think the issue came from #695

@sacrosanctic
Copy link
Contributor Author

createKit runs after createVirtualWorkspace. So the kit context is missing.

@sacrosanctic sacrosanctic marked this pull request as ready for review November 22, 2025 15:06
@manuel3108
Copy link
Member

That's indeed a pretty bad regression, thanks for reporting!
Looks like quite a lot of tests are failing, would you be able to take a look?

@sacrosanctic
Copy link
Contributor Author

I'm unable to resolve the failing tests. I'll need more time to understand what happened in #695.

@jycouet jycouet mentioned this pull request Nov 22, 2025
@jycouet
Copy link
Contributor

jycouet commented Nov 22, 2025

Closes #813 as well!

I added a "cli cli" test with all add-ons. I hope that with it we will be able to catch more things earlier 🤞
Waiting for your review

@jycouet jycouet requested a review from manuel3108 November 22, 2025 21:17
Copy link
Contributor

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ;)

@sacrosanctic
Copy link
Contributor Author

CI is flaky...

@manuel3108 manuel3108 linked an issue Nov 23, 2025 that may be closed by this pull request
@manuel3108 manuel3108 changed the title fix: kit detection fix(cli): kit projects were detected incorrectly Nov 23, 2025
Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@manuel3108
Copy link
Member

CI is flaky...

Always has been, at least for the last 2-3 moths. #781 should hopefully improve this!

@manuel3108 manuel3108 merged commit 10cefa9 into sveltejs:main Nov 23, 2025
6 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Nov 23, 2025
@sacrosanctic sacrosanctic deleted the fix-kit-detection branch November 23, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error during library creation [CLI] Inconsistent CSS file location when adding Tailwind CSS via npx sv add vs initial setup

3 participants