-
-
Notifications
You must be signed in to change notification settings - Fork 69
fix(cli): kit projects were detected incorrectly
#810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b38a211 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
I think the issue came from #695 |
|
|
|
That's indeed a pretty bad regression, thanks for reporting! |
|
I'm unable to resolve the failing tests. I'll need more time to understand what happened in #695. |
|
Closes #813 as well! I added a "cli cli" test with all add-ons. I hope that with it we will be able to catch more things earlier 🤞 |
jycouet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ;)
|
CI is flaky... |
kit detectionkit projects were detected incorrectly
manuel3108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Always has been, at least for the last 2-3 moths. #781 should hopefully improve this! |
closes #809