-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: add support for trailing slashes in typed routes #14065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0096db2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for trailing slashes in typed routes to fix issue #14047. The change ensures that both versions of pathnames (with and without trailing slashes) are included in the generated type definitions.
Key changes:
- Modified pathname generation logic to include trailing slash variants for all non-root routes
- Added test cases to verify trailing slash support in typed routes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/kit/src/core/sync/write_types/index.js | Core logic update to generate both trailing and non-trailing slash pathname types |
packages/kit/src/core/sync/write_types/test/app-types/+page.ts | Test cases added to verify trailing slash pathname support |
.changeset/curvy-bugs-build.md | Changeset documentation for the patch fix |
const replaced_pathname = replace_required_params(replace_optional_params(pathname)); | ||
pathnames.add(`\`${replaced_pathname}\` & {}`); | ||
|
||
if (pathname !== '/') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to add trailing slash only when export const trailingSlash = 'always';
is in a file.
But I could find a way to check it.
|
||
if (pathname !== '/') { | ||
// Support trailing slash | ||
pathnames.add(`\`${replaced_pathname + '/'}\` & {}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I just add a trailing slash to type Pathname
because user would not enter Router Id in href
.
Sorry if I'm wrong.
Fixes #14047
Add pathnames with a trailing slash when generating typed routes.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits