Skip to content

fix: add support for trailing slashes in typed routes #14065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuki0418
Copy link

Fixes #14047

Add pathnames with a trailing slash when generating typed routes.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@Copilot Copilot AI review requested due to automatic review settings July 27, 2025 13:48
Copy link

changeset-bot bot commented Jul 27, 2025

🦋 Changeset detected

Latest commit: 0096db2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for trailing slashes in typed routes to fix issue #14047. The change ensures that both versions of pathnames (with and without trailing slashes) are included in the generated type definitions.

Key changes:

  • Modified pathname generation logic to include trailing slash variants for all non-root routes
  • Added test cases to verify trailing slash support in typed routes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/kit/src/core/sync/write_types/index.js Core logic update to generate both trailing and non-trailing slash pathname types
packages/kit/src/core/sync/write_types/test/app-types/+page.ts Test cases added to verify trailing slash pathname support
.changeset/curvy-bugs-build.md Changeset documentation for the patch fix

const replaced_pathname = replace_required_params(replace_optional_params(pathname));
pathnames.add(`\`${replaced_pathname}\` & {}`);

if (pathname !== '/') {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add trailing slash only when export const trailingSlash = 'always'; is in a file.
But I could find a way to check it.


if (pathname !== '/') {
// Support trailing slash
pathnames.add(`\`${replaced_pathname + '/'}\` & {}`);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I just add a trailing slash to type Pathname because user would not enter Router Id in href.
Sorry if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resolve() lacks a trailing slash when using trailingSlash = always
1 participant