Skip to content

docs: remote files can be in lib or routes dir #14091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Aug 1, 2025

First step for #14077


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 1, 2025

⚠️ No Changeset found

Latest commit: 818441c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@aster-void
Copy link

Could you make this sound more like a warning (you can't place remote files outside of...) rather than giving permission (you can place them inside...)? People would naturally assume it's allowed everywhere, since .server.js/ts files can be placed anywhere.

@jycouet
Copy link
Contributor Author

jycouet commented Aug 2, 2025

Could you make this sound more like a warning (you can't place remote files outside of...) rather than giving permission (you can place them inside...)? People would naturally assume it's allowed everywhere, since .server.js/ts files can be placed anywhere.

It was to sound positive of what is handled. But you are maybe right... I don't know.

Currently putting remote flies inside lib files and importing server variables like db, auth causes
Cannot import $lib/server/myfunction.remote.ts into client-side code. This could leak sensitive information.

This is maybe another issue ?!
Having the /server/ segment in the path ?
Because it should be possible to use server stuff in remote files.

@aster-void
Copy link

Currently putting remote flies inside lib files and importing server variables like db, auth causes
Cannot import $lib/server/myfunction.remote.ts into client-side code. This could leak sensitive information.

This may be because files under src/lib/server are considered server modules, just like .server.js/ts, and cannot be imported by client module. That seems like a big foot gun as well, but should be handled by another PR (imo).

@benmccann benmccann added the documentation Improvements or additions to documentation label Aug 6, 2025
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
@jycouet jycouet requested a review from eltigerchino August 6, 2025 05:37
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Wasn't sure if my suggestion was too strongly worded with the "must" inserted into it but I'm sure that can be changed in the future if someone can phrase it better (or we remove it entirely with your other PR).

@eltigerchino eltigerchino merged commit bb6fc44 into sveltejs:main Aug 6, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants