-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: remote files can be in lib or routes dir #14091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remote files can be in lib or routes dir #14091
Conversation
|
Could you make this sound more like a warning (you can't place remote files outside of...) rather than giving permission (you can place them inside...)? People would naturally assume it's allowed everywhere, since .server.js/ts files can be placed anywhere. |
It was to sound positive of what is handled. But you are maybe right... I don't know.
This is maybe another issue ?! |
This may be because files under src/lib/server are considered server modules, just like .server.js/ts, and cannot be imported by client module. That seems like a big foot gun as well, but should be handled by another PR (imo). |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Wasn't sure if my suggestion was too strongly worded with the "must" inserted into it but I'm sure that can be changed in the future if someone can phrase it better (or we remove it entirely with your other PR).
First step for #14077
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits