fix: wait for commit promise instead of settled
#14818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now fork every time, we should wait on the commit promise rather than
settled(there are technically a couple of svelte versions wheresettledis there and works but notforkso maybe we could also wait forsettledconcurrently, but I'd say it's probably overkill).Without this, #14800 is basically non-useful since settled resolves immediately if we invoke it after awaiting
load_cache_fork😅P.s. for some reason running the test locally I see a bunch of failing tests...but that's also true before the change so 🤷🏼
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits