This repository was archived by the owner on Oct 13, 2022. It is now read-only.
[Offline] Ignoring query string in static files#150
Open
bekliev wants to merge 1 commit intosveltejs:masterfrom
bekliev:patch-2
Open
[Offline] Ignoring query string in static files#150bekliev wants to merge 1 commit intosveltejs:masterfrom bekliev:patch-2
bekliev wants to merge 1 commit intosveltejs:masterfrom
bekliev:patch-2
Conversation
Member
|
I made this comment on sveltejs/hn.svelte.dev#3 but it's probably more applicable here:
|
Author
|
You're right query parameters helping us to download again the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite
First you have to approve this PR #148 or #138 to serve cached files through service-worker.
About this PR
If you try to open static file (which has been cached), for example borat pic in the example app:
But if you try to add some query strings, e.g.:
?foo=bar, then it will not work*:So this PR solves above bug and ignores query strings.