This repository was archived by the owner on Oct 13, 2022. It is now read-only.
Adding meta description, apple-touch-icon, and maskable icon#261
Open
edjw wants to merge 1 commit intosveltejs:masterfrom
Open
Adding meta description, apple-touch-icon, and maskable icon#261edjw wants to merge 1 commit intosveltejs:masterfrom
edjw wants to merge 1 commit intosveltejs:masterfrom
Conversation
Contributor
|
I am pretty sure you shouldn't set |
Author
Is the |
Member
|
You can test, but I still don't think it'd overwrite it. I think it's best to include in each individual route |
Member
|
@edjw this PR will need to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current starting Sapper template has some things missing for a 100s Lighthouse score. This PR fixes those issues