Skip to content

fix: do not spread non-enumerable symbols #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
+8 −5
Merged

fix: do not spread non-enumerable symbols #17097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ export function exclude_from_object(obj, keys) {
}

for (var symbol of Object.getOwnPropertySymbols(obj)) {
if (!keys.includes(symbol)) {
if (Object.propertyIsEnumerable.call(obj, symbol) && !keys.includes(symbol)) {
result[symbol] = obj[symbol];
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/tests/runtime-runes/samples/derived-rest-includes-symbol/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { test } from '../../test';

export default test({
html: `<p>42</p>`
html: `<p>true false</p>`
});
9 changes: 6 additions & 3 deletions packages/svelte/tests/runtime-runes/samples/derived-rest-includes-symbol/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<script>
const symbol = Symbol();
const symbol1 = Symbol();
const symbol2 = Symbol();

let a = { [symbol1]: 42 };
Object.defineProperty(a, symbol2, { enumerable: false, value: "nope" })

let a = { [symbol]: 42 };
let { ...b } = $derived(a);
</script>

<p>{b[symbol]}</p>
<p>{symbol1 in b} {symbol2 in b}</p>
Loading