🐛 fix(collapse): prevent animation on collapse#118
Closed
LukasEifel wants to merge 1 commit intosveltestrap:mainfrom
Closed
🐛 fix(collapse): prevent animation on collapse#118LukasEifel wants to merge 1 commit intosveltestrap:mainfrom
LukasEifel wants to merge 1 commit intosveltestrap:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes?
This prevents the open animation from being triggered while the navigation bar is collapsed.
If isOpen was set to false and the navbar was collapsed, the animation to close the navbar was played.
This is an implementation of code changes that were made in bestguy/sveltestrap#457.
Fixes #62