Added things to get data from a BMW-712 device on a Particle device#1
Open
RickardPettersson wants to merge 5 commits intosvenp:masterfrom
Open
Added things to get data from a BMW-712 device on a Particle device#1RickardPettersson wants to merge 5 commits intosvenp:masterfrom
RickardPettersson wants to merge 5 commits intosvenp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, i am a system developer and find code to read data from Victron VE.Direct and that repository had some forks and one of them was yours fork with good changes but you haved removed some labels in the library needed for BMW devices so i added them and then i added example files for use with Particle devices.
I also clean up some files in the root folder i dont like to be there.