-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/committeeclash #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/committeeclash #523
Conversation
…for checking if staging or development
32223db to
156a6b8
Compare
…le in .env as in nginx config for committeeclash
c67cd7d to
4a13f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds Ansible configuration for deploying the CommitteeClash application with Docker Compose support. The implementation includes environment-specific configurations for both staging and production environments.
- Adds a new
committeeclashAnsible role with Docker Compose deployment configuration - Enhances the generic Docker Compose task to support custom compose file names
- Configures nginx reverse proxy settings and SSL certificates for CommitteeClash endpoints
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ansible/roles/docker/tasks/compose-up.yml | Enhanced to support custom compose file names via compose_file parameter |
| ansible/roles/committeeclash/vars/main.yml | Defines port numbers and project source path for CommitteeClash |
| ansible/roles/committeeclash/templates/*.j2 | Template files for environment variables, secrets, and nginx configuration |
| ansible/roles/committeeclash/tasks/main.yml | Main deployment tasks including user creation, git clone, and nginx setup |
| ansible/main.yml | Adds committeeclash role to the main playbook |
| ansible/group_vars/*/vars.yml | Environment-specific configuration for staging and production |
| ansible/group_vars/all/websites.yml | SSL certificate configuration for CommitteeClash domains |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 0 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
is dit al succesvol gedeployed op staging? |
Ja, dit zijn de instellingen waarmee die nu op staging gedeployed is. (Zie docs.committeeclash.dev.svsticky.nl en committeeclash.svsticky.nl) |
SilasPeters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! This is a big PR so my comments are not unexpected
|
Looks dope on |
On production "https://commissiestrijd.svsticky.nl" will also be available. But even as with outline (where the alias wiki.dev.svsticky.nl doesn't work), this alias isn't working on dev either. |
SilasPeters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Committeeclash settings for ansible