Skip to content

Conversation

@rensvmoorsel
Copy link
Contributor

@rensvmoorsel rensvmoorsel commented Sep 25, 2025

Committeeclash settings for ansible

@KoenDR06 KoenDR06 changed the title Feat/committeclash Feat/committeeclash Sep 25, 2025
…le in .env as in nginx config for committeeclash
@rensvmoorsel rensvmoorsel requested review from Copilot and removed request for SilasPeters September 28, 2025 20:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds Ansible configuration for deploying the CommitteeClash application with Docker Compose support. The implementation includes environment-specific configurations for both staging and production environments.

  • Adds a new committeeclash Ansible role with Docker Compose deployment configuration
  • Enhances the generic Docker Compose task to support custom compose file names
  • Configures nginx reverse proxy settings and SSL certificates for CommitteeClash endpoints

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ansible/roles/docker/tasks/compose-up.yml Enhanced to support custom compose file names via compose_file parameter
ansible/roles/committeeclash/vars/main.yml Defines port numbers and project source path for CommitteeClash
ansible/roles/committeeclash/templates/*.j2 Template files for environment variables, secrets, and nginx configuration
ansible/roles/committeeclash/tasks/main.yml Main deployment tasks including user creation, git clone, and nginx setup
ansible/main.yml Adds committeeclash role to the main playbook
ansible/group_vars/*/vars.yml Environment-specific configuration for staging and production
ansible/group_vars/all/websites.yml SSL certificate configuration for CommitteeClash domains

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 0 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@svsticky svsticky deleted a comment from Copilot AI Sep 28, 2025
@SamStaijen
Copy link
Member

is dit al succesvol gedeployed op staging?

@rensvmoorsel
Copy link
Contributor Author

rensvmoorsel commented Sep 29, 2025

is dit al succesvol gedeployed op staging?

Ja, dit zijn de instellingen waarmee die nu op staging gedeployed is. (Zie docs.committeeclash.dev.svsticky.nl en committeeclash.svsticky.nl)

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! This is a big PR so my comments are not unexpected

@SilasPeters
Copy link
Member

Looks dope on committeeclash.dev.svsticky.nl! Perhaps a dutch alias would be nice because I keep mispelling comittee

@rensvmoorsel
Copy link
Contributor Author

Looks dope on committeeclash.dev.svsticky.nl! Perhaps a dutch alias would be nice because I keep mispelling comittee

On production "https://commissiestrijd.svsticky.nl" will also be available. But even as with outline (where the alias wiki.dev.svsticky.nl doesn't work), this alias isn't working on dev either.

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@rensvmoorsel rensvmoorsel merged commit 0f40d32 into master Sep 29, 2025
1 check passed
@rensvmoorsel rensvmoorsel deleted the feat/committeclash branch September 29, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants