Skip to content

DRAFT: Add harbor #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SamStaijen merged 10 commits into from
Oct 13, 2025
Merged

DRAFT: Add harbor #528

SamStaijen merged 10 commits into from
Oct 13, 2025

Conversation

@SamStaijen
Copy link
Member

@SamStaijen SamStaijen commented Sep 29, 2025 •
edited
Loading

TODO:

  • make linter happy
  • migrate to good s3

@SamStaijen
Copy link
Member Author

SamStaijen commented Sep 29, 2025

@SilasPeters @rensvmoorsel willen jullie vast een eerste review geven? ik hoef in theorie hier niks meer te doen, alleen nog maar in bitwarden, maar toch hou ik hem nog even op draft

@SamStaijen
Copy link
Member Author

SamStaijen commented Sep 29, 2025 •
edited
Loading

@SilasPeters @rensvmoorsel willen jullie vast een eerste review geven? ik hoef in theorie hier niks meer te doen, alleen nog maar in bitwarden, maar toch hou ik hem nog even op draft

en natuurlijk prod creds toevoegen in BW en onder group_vars (copy/paste van staging group_vars folder)

@SamStaijen
Copy link
Member Author

SamStaijen commented Sep 29, 2025

goed om te weten: harbor wil een eigen nginx dockerimage runnen (met custom config ofzo). die kun je er wel uit slopen, maar ik vond het makkelijker om lekker een proxytje te maken, en dat geeft meer kans op forward/bakcwards compatability leek me

KoenDR06
KoenDR06 reviewed Sep 29, 2025
View reviewed changes
SilasPeters
SilasPeters requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big significant changes requested, so almost there!

@SamStaijen SamStaijen marked this pull request as ready for review October 13, 2025 16:04
@SamStaijen SamStaijen merged commit f46c86f into master Oct 13, 2025
1 check passed
@SamStaijen SamStaijen deleted the feat/add-harbor branch October 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KoenDR06 KoenDR06 KoenDR06 left review comments

@SilasPeters SilasPeters SilasPeters approved these changes

@rensvmoorsel rensvmoorsel Awaiting requested review from rensvmoorsel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SamStaijen @SilasPeters @KoenDR06