Skip to content

Fix an issue where the mousedown event caused groups to be selected when child items were clicked #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axelboberg merged 1 commit into from
Nov 11, 2025
Merged

Fix an issue where the mousedown event caused groups to be selected when child items were clicked #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions plugins/rundown/app/components/RundownList/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,23 @@ function scrollIntoView (el, animate = true, centered = true) {
})
}

/**
* Blur the currently active element,
* this should be called on mousedown
* as that will enable the following
* focus event
*
* Without this an element that just was focused won't
* trigger the focus event when clicked a second time,
* causing the CMD+select operation to have no effect –
* when it should, in fact, unselect the item
*
* mousedown is always triggered before focus
*/
function blurActiveElementBeforeFocus () {
document.activeElement?.blur()
}

export function RundownList ({
rundownId = '',
className = '',
Expand Down Expand Up @@ -277,26 +294,7 @@ export function RundownList ({
bridge.commands.executeCommand('rundown.moveItem', rundownId, newIndex, itemId)
}

async function handleFocus (itemId, eventType) {
/*
This handler will be called on both focus and mousedown events
as focus won't be triggered if the item was already in focus

As mousedown will always trigger before focus we can skip
the event if we know that focus will be triggered

So below we're keeping track of the last focused element
to determine if the focus event will be called so that
we can avoid double-triggers
*/
if (focusRef.current === itemId && eventType === 'focus') {
return
}
if (focusRef.current !== itemId && eventType === 'mousedown') {
return
}
focusRef.current = itemId

async function handleFocus (itemId) {
/*
Handle selection
using the meta key
Expand Down Expand Up @@ -408,8 +406,8 @@ export function RundownList ({
index={i}
rundownId={rundownId}
onDrop={e => handleDrop(e, i)}
onFocus={e => handleFocus(item.id, 'focus')}
onMouseDown={e => handleFocus(item.id, 'mousedown')}
onFocus={e => handleFocus(item.id)}
onMouseDown={e => blurActiveElementBeforeFocus()}
extraContextItems={ExtraContextComponent}
selected={isSelected}
>
Expand Down