fix(ls): external refs should not be validated #5015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-hebel-sb
changed the title
glowcloud
reviewed
Sep 22, 2025
| targets: [{ path: '$ref' }], | ||
| function: 'apilintValueRegex', | ||
| params: ['^(?!.*#/components/schemas).*$'], | ||
| params: ['^(?!.*#/components/schemas)(?!https?://).*$'], |
There was a problem hiding this comment.
Would this not mean that only external references starting with http(s):// are not validated? We could have any URI here, some examples here:
There was a problem hiding this comment.
good point! Changed to validating local references only
glowcloud
approved these changes
Sep 22, 2025
robert-hebel-sb
deleted the
fix/dont-run-validation-against-external-refs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes unwanted validation errors against external refs