feat: parser adapter for json in asyncapi3 #5048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowcloud
reviewed
Nov 18, 2025
packages/apidom-parser-adapter-asyncapi-json-3/test/__snapshots__/adapter.mjs.snap
Show resolved
Hide resolved
glowcloud
reviewed
Nov 18, 2025
glowcloud
approved these changes
Nov 19, 2025
Contributor
glowcloud
left a comment
glowcloud
left a comment
There was a problem hiding this comment.
Looks good now, just small nitpicks.
| [ | ||
| 'application/vnd.aai.asyncapi;version=3.0.0', | ||
| 'application/vnd.aai.asyncapi+json;version=3.0.0', | ||
| 'application/vnd.aai.asyncapi+yaml;version=3.0.0', |
Contributor
There was a problem hiding this comment.
Let's remove the YAML versions here as this is only JSON parser.
Suggested change
| 'application/vnd.aai.asyncapi+yaml;version=3.0.0', |
| 'application/vnd.aai.asyncapi+yaml;version=3.0.0', | ||
| 'application/vnd.aai.asyncapi;version=3.0.1', | ||
| 'application/vnd.aai.asyncapi+json;version=3.0.1', | ||
| 'application/vnd.aai.asyncapi+yaml;version=3.0.1', |
Contributor
There was a problem hiding this comment.
Suggested change
| 'application/vnd.aai.asyncapi+yaml;version=3.0.1', |
|
|
||
| ### detect | ||
|
|
||
| [Detection](https://github.com/swagger-api/apidom/blob/main/packages/apidom-parser-adapter-asyncapi-json-3/src/adapter.ts#L13) is based on a regular expression matching required AsyncApi 3.0.0 specification symbols in JSON format. |
Contributor
There was a problem hiding this comment.
This should point to the detect function:
Suggested change
| [Detection](https://github.com/swagger-api/apidom/blob/main/packages/apidom-parser-adapter-asyncapi-json-3/src/adapter.ts#L13) is based on a regular expression matching required AsyncApi 3.0.0 specification symbols in JSON format. | |
| [Detection](https://github.com/swagger-api/apidom/blob/main/packages/apidom-parser-adapter-asyncapi-json-3/src/adapter.ts#L18) is based on a regular expression matching required AsyncApi 3.0.0 specification symbols in JSON format. |
| let processedText; | ||
| const nameSpace = await findNamespace(text, this.settings?.defaultContentLanguage); | ||
| // TODO: Turned off validation, because we will implement it in the future. | ||
| if (nameSpace.namespace === 'asyncapi' && nameSpace.version === '3.0.0') { |
Contributor
There was a problem hiding this comment.
Do we need to turn it off for the 3.0.1 version as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser adapter for asyncapi JSON 3