fix: issue-4 implementation#7
Open
dragonfruit-blue wants to merge 2 commits intoswe-productivity:mainfrom
Open
fix: issue-4 implementation#7dragonfruit-blue wants to merge 2 commits intoswe-productivity:mainfrom
dragonfruit-blue wants to merge 2 commits intoswe-productivity:mainfrom
Conversation
anomolous-lemur
suggested changes
Mar 22, 2026
anomolous-lemur
left a comment
anomolous-lemur
left a comment
There was a problem hiding this comment.
Thanks for the PR, @dragonfruit-blue -- just a few minor comments below.
.gitignore
Outdated
| __pycache__/ | ||
| *.pytest_cache/ | ||
|
|
||
| data/* No newline at end of file |
There was a problem hiding this comment.
This change is out-of-place in this PR.
| // } | ||
|
|
||
| // Apply angle mode transformations for angle dimensions | ||
| if (Type.isValue("Angle") || Type.isValue("Angle3Pt")) { |
There was a problem hiding this comment.
You're missing the else clause here - the original code negated things that were marked as Inverted but were not "Angle" or "Angle3Pt".
Comment on lines
+700
to
+707
| // if (Inverted.getValue()) { | ||
| // if (Type.isValue("Angle") || Type.isValue("Angle3Pt")) { | ||
| // result = CircleDegrees - result; | ||
| // } | ||
| // else { | ||
| // result = -result; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Drop all of the commented out code blocks.
|
Thanks for the changes -- .gitignore is still touched. Do you need help removing that change from this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Summary
This PR implements the changes required for issue #4.
##Changes
Issues
Closes #4