Base: Enhance Bitmask with constexpr support and exhaustive tests#9
Open
dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
Open
Base: Enhance Bitmask with constexpr support and exhaustive tests#9dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
dragonfruit-blue wants to merge 1 commit intoswe-productivity:mainfrom
Conversation
dragonfruit-blue
force-pushed
the
issue-3
branch
from
40da41a to
5f83dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Base::Flags class with constexpr support, fixed operator!, and new operators (^, ^=, ==, !=). It also adds an exhaustive test suite in tests/src/Base/Bitmask.cpp to ensure robustness and prevent regressions.