Various Bug Fixes and Minor Refactors#3
Open
h423l-dev wants to merge 8 commits intoswelljoe:masterfrom
Open
Conversation
Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
because we really want to set e. Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
setting 'set -e' in a script that is sourced by other scripts can cause unexpected exits in the caller’s environment. dependencies should not dictate error-handling behavior for scripts that source them. this change ensures that the calling scripts remain in control of whether they exit on errors, while still allowing internal logging commands to handle errors safely if needed. Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
the previous implementation used '$(tty -s)' inside a test expression, which always evaluated to false because 'tty -s' produces no output. it also spawned an unnecessary subprocess. the logic now uses '[ -t 1 ] && [ -n "$TERM" ]' to check whether stdout is a terminal and a valid terminal type is defined. this approach is faster, simpler, and fully POSIX-compliant. Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
Signed-off-by: Hary Zeldon <hary.zeldon@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request includes several updates and improvements across multiple areas.
All changes are documented and explained in detail in the individual commit messages. Please refer to them for context and rationale behind each modification.