Skip to content

Revert "[ci] : Remove deprecated options on unit-test action" #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Revert "[ci] : Remove deprecated options on unit-test action" #513

merged 1 commit into from
May 16, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 16, 2025 •
edited
Loading

Reverts #510

I think the issue #509 that caused this tests disabling has been resolved in Swift and would like to confirm here as well.

@ktoso ktoso requested a review from sebsto May 16, 2025 04:51
@ktoso ktoso added the semver/none No version bump required. label May 16, 2025
@ktoso ktoso closed this May 16, 2025
@ktoso ktoso reopened this May 16, 2025
@ktoso
Copy link
Contributor Author

ktoso commented May 16, 2025

resolves #509

sebsto
sebsto reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep

linux_nightly_next_enabled: true

?

@sebsto
Copy link
Contributor

sebsto commented May 16, 2025

OK, got it from https://github.com/apple/swift-nio/blob/main/.github/workflows/unit_tests.yml

6.0
6.1
6.0-nightly
6.1-nightly
nightly-next

are enabled by default

@sebsto sebsto self-assigned this May 16, 2025
sebsto
sebsto approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto sebsto merged commit c7df9bc into main May 16, 2025
63 of 64 checks passed
@sebsto sebsto deleted the revert-510-sebsto/fix_ci_509 branch May 16, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsto sebsto sebsto approved these changes

Assignees

@sebsto sebsto

Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @sebsto